#5906: remove same data format assert for output/intermediate operands #8275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttmtrajkovic
approved these changes
May 9, 2024
rdjogoTT
force-pushed
the
rd/remove_dataformat_assert
branch
from
b796933
to
9b62635
Compare
rdjogoTT
force-pushed
the
rd/remove_dataformat_assert
branch
from
9b62635
to
63d078f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable different op output data formats by removing the assert for all output/intermediate data formats to be the same, as this is a legacy assert.
Now, we can enable different data formats by reconfiguring the packer/unpacker.
Separate issue will be created to review and ensure it is ok for GS and WHB0.
Passing post-commit: https://github.com/tenstorrent/tt-metal/actions/runs/9017957084